Repository navigation
[stable33] fix(session): only regenerate session id after valid remember-me cookie - #64927
Merged
Merged
Conversation
loginWithCookie() regenerated the session id before validating the remember-me cookie. With stale cookies (e.g. after the session token was invalidated by an OIDC backchannel logout) every request rotated the session and failed. Parallel requests then forked the same session, and the browser could end up with a copy lacking data stored during the login, such as user_oidc's OIDC state or the login flow v2 state token. Regenerate the session id only once the cookie has been validated. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5.5
backportbot
Bot
requested review from
a team,
Altahrim,
CarlSchwan,
mejo-,
provokateurin,
salmart-dev and
susnux
and removed request for
a team
September 30, 2026 10:46
backportbot
Bot
added
bug
3. to review
mejo-
approved these changes
Sep 30, 2026
github-actions
Bot
changed the title
DerDreschner
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #64924