Repository navigation
fix(setup): only resolve MySQL SSL attributes when an option is set - #64975
Merged
Merged
Conversation
The PDO MySQL attributes only exist with the pdo_mysql extension, so resolving them unconditionally broke the MySQL setup without any encryption option when the extension is missing, e.g. in the 32-bit test environment. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
provokateurin
approved these changes
Oct 1, 2026
provokateurin
enabled auto-merge
October 1, 2026 08:01
Member
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
4 of 7 tasks
susnux
approved these changes
Oct 1, 2026
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/64975/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e299c08f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64975/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable34
git pull origin stable34
# Create the new backport branch
git checkout -b backport/64975/stable34
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e299c08f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64975/stable34Error: Failed to check for changes with origin/stable34: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PDO MySQL attributes only exist with the pdo_mysql extension, so resolving them unconditionally broke the MySQL setup without any encryption option when the extension is missing, e.g. in the 32-bit test environment.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)