Repository navigation
test(files): fix background scanner paths and ETag propagation checks - #65132
Open
joshtrichards wants to merge 3 commits into
Open
joshtrichards wants to merge 3 commits into
joshtrichards wants to merge 3 commits into
Conversation
When a folder is marked unscanned `(size = -1)`, rescanning must not reuse its cached ETag. Changes to a nested folder's ETag must also propagate to its ancestors. The tests didn't verify that newly added files were discovered. The nested-folder test also checked the wrong path and restored the subfolder's mtime from its parent instead of its own cached mtime. - Assert newly added files are cached - Check the nested file at its correct path - Preserve the subfolder's own mtime during the scan Signed-off-by: Josh <josh.t.richards@gmail.com>
The tests create files under `folder` and `folder2` but repeat an assertion for `folder/bar.txt`; the pre-scan check also uses a path that the fixture never creates. The broader behavior still had some coverage, but a narrow cache-entry regression could go unnoticed. - Check the actual `folder2/bar.txt` path - Clarify why the tests mark folders complete or incomplete Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
icewind1991
and removed request for
a team
October 5, 2026 13:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
folderandfolder2but repeated an assertion forfolder/bar.txt. Additionally, the pre-scan check used a path that the fixture never created.mtimeinstead of the subfolder's own cachedmtime.Changes:
folder2/bar.txtpath.mtimeduring the scan.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)