Skip to content

feat(profile): Add setting for turning profiles private - #65139

Open
come-nc wants to merge 3 commits into
masterfrom
feat/add-private-profile-setting
Open

feat(profile): Add setting for turning profiles private#65139
come-nc wants to merge 3 commits into
masterfrom
feat/add-private-profile-setting

Conversation

@come-nc

@come-nc come-nc commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

This new setting lives in 'settings' application, because the two other profile related settings were already in there. It turns the profile page endpoint into an authenticated page.

I’m interested in feedback, especially on the option formulation and wether is needs an info box as the other two settings.
Current look:
Capture d'écran_20261005_155235
Not that it will be affected by the migration of settings to vue3.

I moved the info box for the second option above it to be consistent with the first option. I don’t know it should be above or below.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@come-nc
feat(profile): Add setting for turning profiles private
20d7b39 
This new setting lives in 'settings' application, because the two other
 profile related settings were already in there. It turns the profile
 page endpoint into an authenticated page.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added this to the Nextcloud 36 milestone Oct 5, 2026
@come-nc come-nc self-assigned this Oct 5, 2026
@come-nc come-nc added 2. developing Work in progress enhancement feature: settings feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Oct 5, 2026
@come-nc

This comment was marked as resolved.

Sign in to view
artonge
artonge reviewed Oct 8, 2026
View reviewed changes

@artonge artonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once the private exception use is migrated to a propre return type.

cc @marcoambrosini regarding the checkbox and notes labels. Maybe you have an idea on how to make it cleaner and less ambiguous.

marcoambrosini
marcoambrosini reviewed Oct 8, 2026
View reviewed changes

@marcoambrosini marcoambrosini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things from my side:

  • first of all, could we use the new switch components?
Image
  • I would flip the first switch into: "Disable profile for new accounts"

@come-nc

come-nc commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

A few things from my side:

  • first of all, could we use the new switch components?

This should be done as part of the vue3 migration that is planned for 36 as well

  • I would flip the first switch into: "Disable profile for new accounts"

I can do that. Should I keep the associated infobox or ditch it?

come-nc added 2 commits October 8, 2026 14:45
@come-nc
fix: Use OCP RedirectResponse instead of OC NotLoggedInException
bf5f9ed 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Fix profile tests
a1830e3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@marcoambrosini

marcoambrosini commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

We could keep "only affects new accounts" in the info box, and later move that to the new component description slot

@come-nc

come-nc commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

It feels to me like it makes more sense to do the rewording at the same time as the vue3 migration which should happen for 36 anyway, so I’m pushing this to review.

@come-nc
come-nc marked this pull request as ready for review October 12, 2026 07:54
@come-nc
come-nc requested review from a team as code owners October 12, 2026 07:54
@come-nc
come-nc requested review from icewind1991, kristian-zendato, leftybournes, pringelmann, provokateurin, skjnldsv and sorbaugh and removed request for a team October 12, 2026 07:54
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge left review comments
@marcoambrosini marcoambrosini marcoambrosini left review comments
@pringelmann pringelmann Awaiting requested review from pringelmann pringelmann is a code owner automatically assigned from nextcloud/server-frontend
@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend
@kristian-zendato kristian-zendato Awaiting requested review from kristian-zendato kristian-zendato is a code owner automatically assigned from nextcloud/server-frontend
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: settings

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

3 participants

@come-nc @marcoambrosini @artonge