Skip to content

fix(preview): handle null location id in deletePreview - #65155

Open
pk7243959-wq wants to merge 3 commits into
nextcloud:masterfrom
pk7243959-wq:fix/preview-cleanup-null-location
Open

pk7243959-wq wants to merge 3 commits into
nextcloud:masterfrom
pk7243959-wq:fix/preview-cleanup-null-location

Conversation

@pk7243959-wq

Copy link
Copy Markdown
  • Resolves: #

Summary

Handle null locationId safely during preview deletion when previews exist without a location ID.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@pk7243959-wq
pk7243959-wq requested a review from a team as a code owner October 5, 2026 21:38
@pk7243959-wq
pk7243959-wq requested review from icewind1991, leftybournes, provokateurin and sorbaugh and removed request for a team October 5, 2026 21:38
@CarlSchwan

Copy link
Copy Markdown
Member

Do you have a backtrace?

@pk7243959-wq

pk7243959-wq commented Oct 6, 2026 via email

Copy link
Copy Markdown
Author

@pk7243959-wq
pk7243959-wq force-pushed the fix/preview-cleanup-null-location branch from 461cc4a to 0e1c174 Compare October 6, 2026 21:09
@pk7243959-wq

Copy link
Copy Markdown
Author

Hi @CarlSchwan,

Unfortunately, I don't have the exact full backtrace from the server logs at hand.

The issue occurs when deletePreview is called on items where the record exists but has a null locationId. Passing null triggers a TypeError in the downstream call.

The check ensures we handle null safely without throwing an exception.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants