Repository navigation
feat: use pre-signed URLS for download from object storage - #65307
Merged
Merged
Conversation
kristian-zendato
requested review from
pringelmann and
susnux
and removed request for
a team
October 8, 2026 07:43
pringelmann
requested changes
Oct 8, 2026
pringelmann
left a comment
Contributor
There was a problem hiding this comment.
Seems good overall but after testing locally the downloads do not work as expected. Happy to approve though if I am missing something on my local setup.
kristian-zendato
force-pushed
the
fix/pre-signed-urls
branch
from
October 8, 2026 14:22
56fd64e to
4851629
Compare
kristian-zendato
requested review from
Altahrim,
CarlSchwan,
leftybournes,
pringelmann and
salmart-dev
and removed request for
a team
October 8, 2026 14:22
susnux
reviewed
Oct 12, 2026
susnux
reviewed
Oct 12, 2026
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
kristian-zendato
force-pushed
the
fix/pre-signed-urls
branch
from
October 13, 2026 13:00
4851629 to
6b4fb87
Compare
susnux
approved these changes
Oct 13, 2026
pringelmann
approved these changes
Oct 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Download a single file in the Files app from object storage when the server provides a pre-signed URL.
The download action requests
oc:downloadURLandnc:download-url-expirationfor that file only. If the URL is present and not expired, the browser fetches it directly and skips the WebDAVHEAD, because the signature is forGET. Folders, multi-file downloads, and files without a direct URL still download throughremote.php/dav.This uses the existing WebDAV properties. The storage must have direct downloads enabled (
use_presigned_urlon the primary object store, or Enable Direct Downloads (presigned URLs) on an external S3 mount).Checklist
3. to review, feature component)stable32)AI (if applicable)