Skip to content

Create shares list report + send it by email + diff - #332

Closed
FlorentPoinsaut wants to merge 23 commits into
nextcloud:masterfrom
solution-libre:master
Closed

Create shares list report + send it by email + diff#332
FlorentPoinsaut wants to merge 23 commits into
nextcloud:masterfrom
solution-libre:master

Conversation

@FlorentPoinsaut

@FlorentPoinsaut FlorentPoinsaut commented Sep 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi,

I'm working to add some features (create file report, email it, and diff from month to month).
It's not finished but I'm creating this PR to share my work as I go along and to avoid someone else spending time on the same features.

ToDo:

  • email notification
  • upload files as nextcloud file instead of email attachment
  • diff from month to month
  • README update

@FlorentPoinsaut FlorentPoinsaut changed the title WIP: Send shares list by email + add output option for shareslist command ((JSON + CSV) WIP: Send shares list by email + add output option for shareslist command (JSON + CSV) Sep 28, 2022
@FlorentPoinsaut
FlorentPoinsaut marked this pull request as draft September 29, 2022 07:20
@CarlSchwan

CarlSchwan commented Sep 30, 2022

Copy link
Copy Markdown
Member

I like these features but would it be possible to split this in multiple PR (make it easier to review)

@CarlSchwan
CarlSchwan self-requested a review September 30, 2022 14:36
@CarlSchwan CarlSchwan added the enhancement New feature or request label Sep 30, 2022
@FlorentPoinsaut

FlorentPoinsaut commented Oct 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

OK @CarlSchwan, I keep this PR for my work and I'm creating few PRs with key features as I go.
First one: #336

@FlorentPoinsaut FlorentPoinsaut changed the title WIP: Send shares list by email + add output option for shareslist command (JSON + CSV) WIP: Create shares list report + send it by email Oct 12, 2022
@FlorentPoinsaut FlorentPoinsaut changed the title WIP: Create shares list report + send it by email WIP: Create shares list report + send it by email + diff Oct 12, 2022
CarlSchwan and others added 13 commits October 12, 2022 08:06
@CarlSchwan @FlorentPoinsaut
Show share expiration if it exits
e6757e4 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@CarlSchwan @FlorentPoinsaut
Add filtering
49f42c7 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
Send shares list by email (JSON + CSV)
6e8a338 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
add output option for shareslist command
82364da 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
Update README
534146d 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
Fix getAllShares
6f37d4f 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
use new getAllShares method
449ed34 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@CarlSchwan @FlorentPoinsaut
Show share expiration if it exits
1d2b505 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan @FlorentPoinsaut
Add filtering
3ba68c1 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@FlorentPoinsaut
Write report on Nextcloud instead of send by email
c6fcad8 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
Refacto + class var fixes
5cb6deb 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
Add CSV output format
f776998 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
Fix getAllShares
cc0cf1b 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
FlorentPoinsaut and others added 2 commits October 12, 2022 10:12
@FlorentPoinsaut
Merge branch 'nextcloud:master' into master
08e1bc0
@FlorentPoinsaut
Add an Abstract Command class
95670cc 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
FlorentPoinsaut and others added 2 commits October 13, 2022 16:11
@FlorentPoinsaut
Add diff report
67f299c 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
add permissions mapping
35c98cb 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
Add send command in README
f5d84b5 
Signed-off-by: Florent Poinsaut <florent@solution-libre.fr>
@FlorentPoinsaut
FlorentPoinsaut marked this pull request as ready for review November 3, 2022 15:27
@FlorentPoinsaut

FlorentPoinsaut commented Nov 3, 2022

Copy link
Copy Markdown
Contributor Author

Done! :)

@FlorentPoinsaut

FlorentPoinsaut commented Nov 22, 2022

Copy link
Copy Markdown
Contributor Author

Hi @CarlSchwan!
Does this PR work for you or do youo need some modifications?
Thanks in advance

@CarlSchwan

CarlSchwan commented Nov 22, 2022

Copy link
Copy Markdown
Member

Hi, sorry I was in vacation the last two weeks and I just came back. i'll try to check it out today

@FlorentPoinsaut

FlorentPoinsaut commented Nov 22, 2022

Copy link
Copy Markdown
Contributor Author

Oh great. No rush. I hope you had a great vacation.

@CarlSchwan

CarlSchwan commented Dec 10, 2022

Copy link
Copy Markdown
Member

Please fix eslint and plasm and then I can merge it

@FlorentPoinsaut

FlorentPoinsaut commented Dec 13, 2022

Copy link
Copy Markdown
Contributor Author

Hello @CarlSchwan,
I am sorry but :

  • eslint is out of my scope and It's risky for me to modify VueJS code
  • palsm can't find Nextcloud Core class OC\Core\Command\Base, I understand why but I don't kwon how to fix this. Do you have an idea?

@FlorentPoinsaut FlorentPoinsaut changed the title WIP: Create shares list report + send it by email + diff Create shares list report + send it by email + diff Jan 9, 2024
@FlorentPoinsaut

FlorentPoinsaut commented Jul 12, 2024

Copy link
Copy Markdown
Contributor Author

Hello @CarlSchwan,

Please could you take a some time to check this PR again?

Thank you in advance.

Regards,

@CarlSchwan

CarlSchwan commented Oct 27, 2025

Copy link
Copy Markdown
Member

I couldn't manage to resolve the merge conflicts, so recreated this PR here: #563 with some additional psalm fixes

@CarlSchwan CarlSchwan closed this Oct 27, 2025
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in @FlorentPoinsaut's backlog Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@FlorentPoinsaut FlorentPoinsaut

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FlorentPoinsaut @CarlSchwan