Conversation
sudormant
added
bug
feature: settings ⚙️
…during occ upgrade, update all references Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
sudormant
force-pushed
the
fix/config/ConfigConstantsToConfigLexicon
branch
from
September 16, 2026 14:44
0cdaff0 to
855e287
Compare
Comment on lines
-31
to
-41
| public const ALLOWED_BACKEND_TIMEOFFSET = 45; | ||
| public const SIGNALING_INTERNAL = 'internal'; | ||
| public const SIGNALING_EXTERNAL = 'external'; | ||
|
|
||
| public const EXPERIMENTAL_UPDATE_PARTICIPANTS = 1; | ||
| public const EXPERIMENTAL_RECOVER_SESSION = 2; | ||
| public const EXPERIMENTAL_CHAT_RELAY = 4; | ||
|
|
||
| public const SIGNALING_TICKET_V1 = 1; | ||
| public const SIGNALING_TICKET_V2 = 2; | ||
|
|
Comment on lines
-84
to
-94
| /** | ||
| * 1. Call recording, … | ||
| */ | ||
| public const FEATURE_HINT = 34; | ||
|
|
||
| /** | ||
| * Currently limiting to 1k users because the user_status API would yield | ||
| * an error on Oracle otherwise. Clients should use a virtual scrolling | ||
| * mechanism so the data should not be a problem nowadays | ||
| */ | ||
| public const USER_STATUS_INTEGRATION_LIMIT = 1000; |
Member
There was a problem hiding this comment.
Also this.
And instead we only move config names to the lexicon?
| * Minimum length of the external call service shared secret. Shorter | ||
| * secrets are not considered configured to improve security. | ||
| */ | ||
| protected const EXTERNAL_CALL_SERVICE_SECRET_MIN_LENGTH = 64; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(config): Move Config Constants to ConfigLexicon to allow loading during occ upgrade, update all references
🏁 Checklist
docs/has been updated or is not required