Conversation
Bring in the npm package to migrate off the OCA.Viewer global, which Viewer 2.0 drops (nextcloud/server#63954). Assisted-by: ClaudeCode:claude-sonnet-4-6
OCA.Viewer.open() took loose file-info objects; the package's getViewer().open() wants real IFile node instances instead, so useViewer now builds them from Files/Talk file objects (dav source URL for members, public download link for guests). Talk's own pages never load Files' init script, so register the default image/video/audio handlers here instead. Drop the OCA.Viewer global type, which Viewer 2.0 removes. Assisted-by: ClaudeCode:claude-sonnet-4-6
FilePreview's isViewerAvailable now uses canView() on a built node instead of checking OCA.Viewer.mimetypes. ViewerOverlayCallView closes through getViewer().close(). NewMessageNewFileDialog follows useViewer's new openViewer(list, fileInfo) signature. Assisted-by: ClaudeCode:claude-sonnet-4-6
Antreesy
added
technical debt
feature: frontend 🖌️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
// window.OCA.Viewer = createViewer())AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist