Skip to content

[stable-23.0] Simplifying pinned messages#5821

Merged
mahibi merged 11 commits intostable-23.0from
backport/5807/stable-23.0
Feb 5, 2026
Merged

[stable-23.0] Simplifying pinned messages#5821
mahibi merged 11 commits intostable-23.0from
backport/5807/stable-23.0

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 5, 2026

Backport of PR #5807

@backportbot backportbot bot added the 3. to review Waiting for reviews label Feb 5, 2026
@backportbot backportbot bot added this to the 23.0.0 milestone Feb 5, 2026
rapterjet2004 and others added 11 commits February 5, 2026 16:45
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
…nned message requests

getConversationFlow emits too often, causing multiple overlapping
calls to getIndividualMessageFromServer (i guess this caused the ANR issues).
Using flatMapLatest ensures
that only the latest conversation triggers a network call and cancels previous requests.
This should hopefully avoid the ANR issues.

TODO: improve architecture
-> reduce unnecessary getConversationFlow triggers
-> better MVVM (too many things are inside Activity)

I wont do further changes now to avoid too many changes for v23RC2

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@mahibi mahibi merged commit adea6f1 into stable-23.0 Feb 5, 2026
13 of 15 checks passed
@mahibi mahibi deleted the backport/5807/stable-23.0 branch February 5, 2026 16:48
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5821.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants