Skip to content

fix(table): use small buttons for table actions #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 1 commit into from
Dec 17, 2025
Merged

fix(table): use small buttons for table actions #8079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified playwright/e2e/print.spec.ts-snapshots/Own-file-on-ci-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified playwright/e2e/print.spec.ts-snapshots/Shared-file-on-ci-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 3 additions & 4 deletions src/css/prosemirror.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,12 +341,11 @@ div.ProseMirror {

table {
border-spacing: 0;
width: calc(100% - 50px - var(--default-clickable-area));
// Needs to be sync with `.table-add-row` button width in `TableView.vue`
width: calc(100% - (2 * var(--clickable-area-small)) - 8px);
table-layout: auto;
white-space: normal; // force text to wrapping
margin-bottom: calc(
var(--clickable-area-small) + var(--default-clickable-area)
);
margin-bottom: calc(var(--clickable-area-small) + 8px);
& + * {
margin-top: 1em;
}
Expand Down
6 changes: 3 additions & 3 deletions src/nodes/Table/TableCellView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<NodeViewWrapper data-text-el="table-cell" as="td" :dir="dir" :style="textAlign">
<div class="container">
<NodeViewContent class="content" />
<NcActions v-if="isEditable" data-text-table-actions="row">
<NcActions v-if="isEditable" data-text-table-actions="row" size="small">
<NcActionButton
data-text-table-action="add-row-before"
close-after-click
Expand Down Expand Up @@ -141,10 +141,10 @@ td {

.action-item {
position: absolute;
right: -48px;
right: calc((var(--clickable-area-small) * -1) - 4px);
flex: 0 1 auto;
display: none;
top: 2px;
top: calc((var(--default-clickable-area) - var(--clickable-area-small)) / 2);
}

&:last-child {
Expand Down
2 changes: 2 additions & 0 deletions src/nodes/Table/TableHeaderView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<NcActions
v-if="isEditable"
ref="menu"
size="small"
variant="tertiary-no-background"
data-text-table-actions="header">
<NcActionButtonGroup>
Expand Down Expand Up @@ -214,6 +215,7 @@ th {
}

.action-item {
top: calc((var(--default-clickable-area) - var(--clickable-area-small)) / 2);
opacity: 50%;
}

Expand Down
14 changes: 9 additions & 5 deletions src/nodes/Table/TableView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<NcActions
v-if="isEditable"
force-menu
size="small"
data-text-table-actions="settings"
class="table-settings">
<template #icon>
Expand All @@ -30,6 +31,7 @@
<NcButton
v-if="isEditable"
class="table-add-column"
size="small"
:aria-label="t('text', 'Add column after')"
:title="t('text', 'Add column after')"
@click="addColumnAfter">
Expand All @@ -40,6 +42,7 @@
<NcButton
v-if="isEditable"
class="table-add-row"
size="small"
:aria-label="t('text', 'Add row below')"
:title="t('text', 'Add row below')"
@click="addRowAfter">
Expand Down Expand Up @@ -154,8 +157,8 @@ export default {
padding-left: 3px;
opacity: 0.5;
position: absolute;
top: 0;
right: var(--default-clickable-area);
top: calc((var(--default-clickable-area) - var(--clickable-area-small)) / 2);
right: calc(var(--clickable-area-small) + 4px);

&:hover {
opacity: 1;
Expand All @@ -169,7 +172,7 @@ export default {
position: absolute;
top: var(--default-clickable-area);
right: 0;
bottom: 60px;
bottom: calc(var(--clickable-area-small) + 8px);
margin-top: 0 !important;

&:hover {
Expand All @@ -183,8 +186,9 @@ export default {
opacity: 0.5;
position: absolute;
left: 0;
bottom: 12px;
width: calc(100% - 80px) !important;
bottom: 4px;
// Needs to be in sync with table width in `prosemirror.css`
width: calc(100% - (2 * var(--clickable-area-small)) - 8px) !important;

&:hover {
opacity: 1;
Expand Down
Loading