fix(comparison): make source line labels extractable - #9211
Merged
Merged
Conversation
This was referenced Sep 16, 2026
hweihwang
marked this pull request as ready for review
September 16, 2026 18:52
hweihwang
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
September 16, 2026 18:52
Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
mejo-
force-pushed
the
collectives-599/t1-source-labels
branch
from
September 28, 2026 13:32
1187819 to
3e372fc
Compare
mejo-
approved these changes
Sep 28, 2026
mejo-
left a comment
mejo-
left a comment
Member
There was a problem hiding this comment.
@hweihwang I removed the superfluous tests from the PR.
Member
|
/backport to stable35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9175.
Make the translation tools pick up the Added line and Removed line labels. Keep the guard for empty cells in additions and deletions.
Backport: #9214.
Tests
All 17 Source component tests passed locally. The translation extractor found both keys after the fix on main and stable35; neither appeared before the fix.
AI