perf(session): fetch document only once in SessionMiddleware - #9294
Merged
Merged
Conversation
Endpoints that require both a document session and a matching base version etag (push, sync, save) looked up the document twice per request: once in assertDocumentBaseVersionEtag() and again in assertDocumentSession(). Keep the fetched document in the middleware for the rest of the request so both checks share one query. Supersedes #5773. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5.5
2 tasks
benjaminfrueh
approved these changes
Sep 29, 2026
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoints that require both a document session and a matching base version etag (push, sync, save) looked up the document twice per request: once in assertDocumentBaseVersionEtag() and again in assertDocumentSession(). Keep the fetched document in the middleware for the rest of the request so both checks share one query.
Supersedes #5773.
Assisted-by: ClaudeCode:claude-opus-5.5
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)馃 AI (if applicable)