Closed
Conversation
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Whiteboard library templates end to end:
POST /apps/whiteboard/library/template.excalidrawlibstoragelibraryItemsDependency
Depends on nextcloud-deps/excalidraw#16 for the Excalidraw library menu hook.
Draft note:
package.jsoncurrently points at localfile:dependencies for the patched Excalidraw packages so this branch can be tested locally. Before merge this must be replaced by the published package/version or another shippable package reference from the Excalidraw dependency PR.Validation
npm run lintpassed locallynpm run stylelintpassed locallycomposer lintpassed locallycomposer cs:checkpassed locallynpm testpassed locallynpm run buildpassed locallygit diff --checkpassed locally