[nextest-filtering] handle not(predicate), and better error on prefix and/or#3367
Merged
Conversation
…(a,b) Allow expressions like `not(test(foo))` to be parsed. Fixes #1816.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3367 +/- ##
==========================================
+ Coverage 85.53% 85.57% +0.04%
==========================================
Files 160 160
Lines 47954 48131 +177
==========================================
+ Hits 41017 41188 +171
- Misses 6937 6943 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sunshowers
force-pushed
the
handle-not-no-space
branch
from
6308482 to
893b19e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow expressions like
not(test(foo))to be parsed.Fixes #1816.