Skip to content

fix(skills): instruct agent to use exact absolute path for skill files #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buidackim wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(skills): instruct agent to use exact absolute path for skill files #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/agent/systemprompt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ func buildSkillsSection(skillsSummary string, hasSkillSearch, hasSkillManage boo
"## Skills (mandatory)",
"",
"Before replying, scan `<available_skills>` below.",
"If a skill clearly applies, read its SKILL.md at the `<location>` path with `read_file`, then follow it.",
"If a skill clearly applies, read its SKILL.md at the `<location>` path with `read_file` (use the EXACT absolute path provided), then follow it.",
"If multiple could apply, choose the most specific one. Never read more than one skill up front.",
"If none apply, proceed normally.",
"",
Expand All @@ -655,7 +655,7 @@ func buildSkillsSection(skillsSummary string, hasSkillSearch, hasSkillManage boo
"Before replying, check if a skill applies:",
"1. Run `skill_search` with **English keywords** describing the domain (e.g. \"weather\", \"translate\", \"github\").",
" Even if the user writes in another language, always search in English.",
"2. If a match is found, read its SKILL.md at the returned `location` with `read_file`, then follow it.",
"2. If a match is found, read its SKILL.md at the returned `location` with `read_file` (use the EXACT absolute path provided), then follow it.",
"3. If multiple skills match, choose the most specific one. Never read more than one skill up front.",
"4. If no match, proceed normally.",
"",
Expand Down Expand Up @@ -688,7 +688,7 @@ func buildSkillsSection(skillsSummary string, hasSkillSearch, hasSkillManage boo
func buildWorkspaceSection(workspace string, sandboxEnabled bool, containerDir string) []string {
// Matching TS: when sandboxed, display container workdir; add guidance about host paths for file tools.
displayDir := workspace
guidance := "All file tool paths resolve relative to this directory. Use relative paths (e.g. \"docs/notes.md\", \".\") — do not guess absolute paths."
guidance := "All file tool paths resolve relative to this directory. Use relative paths (e.g. \"docs/notes.md\", \".\") for your own files. For skills, use the EXACT absolute path provided."
if sandboxEnabled && containerDir != "" {
displayDir = containerDir
guidance = fmt.Sprintf(
Expand Down
2 changes: 1 addition & 1 deletion internal/tools/skill_search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func (t *SkillSearchTool) Execute(ctx context.Context, args map[string]any) *Res

// Include explicit next-step instruction in the result so the model follows through.
instruction := fmt.Sprintf(
"\n\nACTION REQUIRED: Call use_skill with name \"%s\", then read_file with path \"%s\" to read the skill instructions, then follow them.",
"\n\nACTION REQUIRED: Call use_skill with name \"%s\", then read_file with path \"%s\" (use the EXACT absolute path provided) to read the skill instructions, then follow them.",
results[0].Name, results[0].Location,
)

Expand Down