Merged
Conversation
9df95e1 to
b5bca26
Compare
becb515 to
a266800
Compare
a266800 to
1720811
Compare
1720811 to
2f53084
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds support for PHP 8.5 to the project by updating test matrices, CI workflows, and Docker configurations. The changes ensure the codebase is tested against PHP 8.5 and includes compatibility fixes for the newer PHP version, including updating test framework dependencies and fixing PHP version range constraints in test matrices.
Changes:
- Added PHP 8.5 to GitHub Actions CI matrix and Docker Compose services
- Updated PHP version maximums from 80499 to 80599 across multiple test matrix files
- Upgraded nette/tester dependency to ~2.5.7 for PHP 8.1+ test matrices
- Fixed PHP 8.1+ compatibility issue with ReflectionMethod::setAccessible() deprecation
- Removed deprecated
-o consoleflag from test runner scripts - Corrected PHP version range in doctrine-3.0-php-7.3-to-7.4.sh (80499 → 70499)
- Added new test matrix file for Doctrine DBAL 3.0 with PHP 8.0-8.5 support
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/qa.yaml | Added PHP 8.5 to the test matrix |
| docker-compose.yaml | Added php85 service using thecodingmachine/php:8.5-v4-cli image |
| tests/run-unit.sh | Removed deprecated -o console flag from tester invocation |
| tests/run-integration.sh | Removed deprecated -o console flag from tester invocation |
| tests/matrix/symfony-bundle/symfony-7.0-php-8.2.sh | Extended PHP version support to 8.5 (PHP_VERSION_MAX: 80599) |
| tests/matrix/dbal/nextras-5.0-php-8.1-to-8.5.sh | Extended PHP version support to 8.5 and upgraded nette/tester to ~2.5.7 |
| tests/matrix/dbal/doctrine-4.0.sh | Extended PHP version support to 8.5 and upgraded nette/tester to ~2.5.7 |
| tests/matrix/dbal/doctrine-3.0-php-8.0.sh | New file: Added test matrix for Doctrine DBAL 3.10.4 with PHP 8.0-8.5 |
| tests/matrix/dbal/doctrine-3.0-php-7.3-to-7.4.sh | Fixed PHP_VERSION_MAX from 80499 to 70499 (correct range for PHP 7.3-7.4) |
| tests/matrix/dbal/dibi-5.0.sh | Extended PHP version support to 8.5 and upgraded nette/tester to ~2.5.7 |
| tests/matrix/dbal/dibi-4.0-php-8.1.sh | Extended PHP version support to 8.5 and upgraded nette/tester to ~2.5.7 |
| tests/cases/unit/OrderResolverTest.phpt | Added PHP version check to conditionally call setAccessible() only for PHP < 8.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Fix php85 Docker image tag (v4 -> v5, v4 doesn't exist for 8.5) - Extend PHP_VERSION_MAX to 80599 in 16 matrix files that are compatible with PHP 8.5 - Keep PHP_VERSION_MAX at 80499 for packages that don't support 8.5: - dibi 5.0 (composer resolution failure) - doctrine/dbal 3.3-3.9 and 4.0-4.2 (deprecated PDO::PGSQL_ATTR_DISABLE_PREPARES)
3e6ca3a to
64a196c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add PHP 8.5 support to nextras/migrations.
Changes
php85to CI matrixphp85service usingthecodingmachine/php:8.5-v5-cliPHP_VERSION_MAXto80599in 16 matrix files for packages compatible with PHP 8.5:dibi-4.2,dibi-5.1,doctrine-3.10,doctrine-4.3,doctrine-4.4,nette-3.2,nextras-5.0symfony-5.4,symfony-6.3,symfony-6.4,symfony-7.0–7.4,symfony-8.0Packages left at PHP 8.4 max
These packages don't support PHP 8.5 yet:
dibi/dibi:5.0.*— composer resolution failure on PHP 8.5doctrine/dbal:3.3.*–3.9.*and4.0.*–4.2.*— use deprecatedPDO::PGSQL_ATTR_DISABLE_PREPARESconstant (fixed in 3.10+ and 4.3+)Test results on PHP 8.5
All 16 eligible matrix entries pass: 168 tests (112 dbal + 56 symfony-bundle), 0 failures.