Improve error model and serialization#44
Improve error model and serialization#44Quinn-With-Two-Ns wants to merge 1 commit intonexus-rpc:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b7fcca303
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| /** Failure stack trace. */ | ||
| public String getStackTrace() { |
There was a problem hiding this comment.
io.nexusrpc is @NullMarked (see package-info.java), so getStackTrace() currently advertises a non-null return type, but Builder#setStackTrace accepts null and build() also leaves it unset by default (covered by FailureInfoTest.builderWithoutStackTrace). This creates FailureInfo instances whose stackTrace is null despite a non-null API contract, so callers that trust the signature can dereference it and hit runtime NPEs.
Useful? React with 👍 / 👎.
Quinn-With-Two-Ns
force-pushed
the
nexus-error-changes
branch
from
3b7fcca to
0d96ba5
Compare
| * @param causeMessage The cause message. | ||
| * @deprecated | ||
| */ | ||
| public HandlerException(ErrorType errorType, String causeMessage) { |
There was a problem hiding this comment.
Seems like we should have a non deprecated constructor that will take just error type and message but I understand that this would break compatibility. In Go we managed to get around this by creating a new constructor but in Java I'm not sure how we might achieve that. Do you think we could remove this deprecated method and bring it back at some point?
| * @param message The cancellation message. | ||
| * @return The operation exception. | ||
| */ | ||
| public static OperationException canceled(String message) { |
There was a problem hiding this comment.
Noticed we are inconsistent with the naming. I would choose failed and canceled over failure and canceled.
2 participants
Improve error model and serialization:
OperationExceptionto have a messageHandlerExceptionto have a messageHandlerException