fix(with-resource): preserve hasValue narrowing - #315
Merged
Conversation
michael-small
requested changes
Aug 28, 2026
michael-small
left a comment
Collaborator
There was a problem hiding this comment.
This change seems great for unnamed resources, but it does not fix named resources.
Repro branch commit, with examples you can intelisense in a component HTML/TS as well as a purposely broken test: ngrx-toolkit/ngrx-toolkit@5b8cb34
Collaborator
Author
|
@michael-small, thanks for your commit on the unnamed resources. I have added some docu about the why and if you approve, we can merge and relase v22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasValueas a function property with an explicit generic receivervalue()to excludeundefinedVerification
verify:all(lint, test, and build for the library and demo)hasValuenarrowing assertions; one unrelated existingAddressResolver.addressfixture error remains