Skip to content

Revert "Merge pull request #140 from niACS/feature/49-add-state-patte…#143

Merged
gregr-ni merged 1 commit into
ni:developfrom
shivaprasad-basavaraj:revertSPA
Oct 28, 2025
Merged

Revert "Merge pull request #140 from niACS/feature/49-add-state-patte…#143
gregr-ni merged 1 commit into
ni:developfrom
shivaprasad-basavaraj:revertSPA

Conversation

@shivaprasad-basavaraj

Copy link
Copy Markdown
Collaborator

After discussiosn with @elijah286 we decided that the State Pattern Actor should go into its own repo. I have created a repo for State Pattern actor at https://github.com/ni/state-pattern-actor.

This reverts commit 24a309d, reversing changes made to d81df65.

GitHub Issue for the Pull Request

Link to the relevant GitHub issue

GitHub Discussions Related to this Pull Request

List any GitHub discussion links related to this PR

Checklists

Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.

  • I do not require assistance from NI to complete any of the following checks.
  • The changes in this PR are based on the appropriate NI-repo feature branch
  • I am submitting the changes in this PR to the appropriate NI-repo feature branch
  • I built a VI Package using the Powershell build tool.
  • I installed the VI Package produced by the Powershell build tool and tested my change.
  • I tested my changes after installing the VI package.
  • NI has my contributor license agreement.

Summary of Changes

Revert addition of State Pattern Actor into this repo

Reason for Change

State Pattern Actor has its own repo now.

Visual Aids

Include any visual aids that would help the reviewer gain additional context.

Additional Information

Include any further details that may assist the reviewer in understanding the context of this PR.

Testing

This section describes the automated and manual tests performed for this bugfix/feature.

Manual Tests

Describe any manual tests conducted.

…tern-actor-to-the-open-source-repository"

This reverts commit 24a309d, reversing
changes made to d81df65.
@shivaprasad-basavaraj

Copy link
Copy Markdown
Collaborator Author

@niACS This PR reverts the addition of State Pattern Actor into the Actor Framework repo since we decided to move it into its own repo.

@gregr-ni
gregr-ni requested review from gregr-ni and removed request for elijah286 October 28, 2025 13:35
@gregr-ni
gregr-ni merged commit e9cf04e into ni:develop Oct 28, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants