Update to Angular 21 - #3037
Open
m-akinc wants to merge 15 commits into
Open
Conversation
m-akinc
requested review from
fredvisser,
jattasNI,
mollykreis and
rajsite
as code owners
August 19, 2026 22:17
m-akinc
commented
Aug 19, 2026
| "peerDependencies": { | ||
| "@eslint/markdown": "^8.0.1", | ||
| "@ni/eslint-config-angular": "^12.0.1", | ||
| "@ni/eslint-config-angular": "../../ni-eslint-config-angular-13.0.0.tgz", |
Contributor
Author
There was a problem hiding this comment.
Need to replace this with published version, once it exists.
Dependency ReviewThe following issues were found:
|
jattasNI
reviewed
Aug 20, 2026
rajsite
reviewed
Aug 20, 2026
jattasNI
reviewed
Aug 25, 2026
| @@ -1,5 +1,5 @@ | |||
| import { enableProdMode } from '@angular/core'; | |||
Contributor
There was a problem hiding this comment.
I poked around in the example app linked from the storybook build for this PR. Everything I tried behaved as expected except that the spright chat conversation section auto scroll stopped working. (Type "start" in the chat and it's supposed to print a scrolling message but now it prints nothing until you type another message).
I have no idea why that specifically would break with this upgrade, but I reproduced it in multiple browsers (Firefox and Edge).
m-akinc
force-pushed
the
users/makinc/nimble-a21
branch
from
August 25, 2026 18:15
7a28d50 to
cc189ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Adopting Angular 21
👩💻 Implementation
@ni/eslint-config-angular🧪 Testing
Automated tests pass.