Skip to content

Prevent error squiggles in editor for Jasmine types - #3040

Merged
rajsite merged 8 commits into
mainfrom
users/makinc/fix-editor-jasmine-squiggles
Aug 25, 2026
Merged

Prevent error squiggles in editor for Jasmine types#3040
rajsite merged 8 commits into
mainfrom
users/makinc/fix-editor-jasmine-squiggles

Conversation

@m-akinc

@m-akinc m-akinc commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Pull Request

🤨 Rationale

When viewing Angular workspace test files in the VS Code editor, all Jasmine types would be unrecognized and have red error squiggles.

👩‍💻 Implementation

Turn Angular root tsconfig.json into a solution-style tsconfig by adding references to the others.

🧪 Testing

Manual, local testing.

@m-akinc
m-akinc enabled auto-merge (squash) August 21, 2026 20:53
Comment thread change/@ni-nimble-angular-7a57f8ac-b715-4687-a1e8-aa79da2d51b7.json
@m-akinc
m-akinc requested a review from rajsite August 21, 2026 22:19
@m-akinc
m-akinc requested a review from rajsite August 24, 2026 21:03

@rajsite rajsite left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions in PR review were not resolved

@m-akinc
m-akinc requested a review from rajsite August 25, 2026 16:57
@rajsite
rajsite disabled auto-merge August 25, 2026 17:50
@rajsite

rajsite commented Aug 25, 2026

Copy link
Copy Markdown
Member

bypassing @mollykreis for straightforward config change

@rajsite
rajsite merged commit 50f1422 into main Aug 25, 2026
10 checks passed
@rajsite
rajsite deleted the users/makinc/fix-editor-jasmine-squiggles branch August 25, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants