fix(chat): ready Kiro sessions list 对方命令 from vendor ACP notification - #365
Merged
Merged
Conversation
Kiro declares native commands on `_kiro.dev/commands/available` after session/new, not standard available_commands_update. Merge commands[] into Options so a ready Kiro session lists 对方命令 like Grok. Keep prompts/skills/tools out of bare `/` and fail-closed when undeclared. Co-authored-by: NiceChen <nicechencs@gmail.com>
Shared catalog-mirror expected "待验证接入" while core already advertises writable local MCP config. Update the fixture; do not revert product text. Co-authored-by: NiceChen <nicechencs@gmail.com>
Mock capabilities still said planned/待验证接入 after the shared catalog fixture adopted writable local MCP text. Co-authored-by: NiceChen <nicechencs@gmail.com>
Replace the stale “no true-window evidence” line. Ready Kiro lists declared native commands on tip daed5cc; skills catalog stays off bare `/`. Point to the QA retest note, without overclaiming send or other agents. Co-authored-by: NiceChen <nicechencs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
QA tip
3a2f9551(0.4.18):就绪的 Kiro 会话输入裸/只有「立刻执行」,没有「对方命令」。同 tip 下就绪的 Grok 会列出对方命令,选中无参/flush会当真一轮发出。相关:#361 / STATUS「Grok / Kiro 会话就绪且对方声明了命令时,另列对方斜杠项」。
根因
Kiro 会声明对方命令,但不是标准 ACP
available_commands_update。官方文档与实机协议(
kiro-cli acp)在session/new之后发厂商通知_kiro.dev/commands/available:commands[]:斜杠命令,名称常带前导/(如/context)prompts[]:技能,不是斜杠命令tools[]/mcpServers[]:不是斜杠命令Grok 走标准
session/update+available_commands_update,现有grok_session_update能写入 Options。Kiro 这条厂商通知落在notification()的_ => {},目录一直是空的,UI 按 fail-closed 不画「对方命令」。这不是 readiness / provider id 门闩:sessionReady仍看thread_id,Kiro 与 Grok 共用 ACP 通道。未声明的 Agent(Pi / Codex / DeepSeek)继续不画假项。
改动
_kiro.dev/commands/available的commands[],去掉前导/,写入native_commands,bumpcatalog_epochavailable_commands_update对 Kiro 仍然有效(若对方以后改走标准 ACP)prompts/ 技能 / 工具摊进裸/commands[]仍 fail-closed/名字」路径,不代发_kiro.dev/commands/execute文档(合前补记)
docs/STATUS.md/菜单已去掉「没有真窗证据前不宣称对方命令已验收」。现记:Kiro 就绪会话「对方命令」Linux 真窗 PASS(修复 tipdaed5ccf,现行 tip 仍含该修复);裸/不摊技能目录;记录/workspace/qa-issues/CHAT-SLASH-PR365-RETEST-daed5ccf.md。不把选中发送或其它 Agent 写成已验收。CI 修绿
shared_catalog_fixture_covers_capability_reasons:core Grok MCP 文案已是「可写入本机 MCP 配置(目录/探测/启用;无 OAuth)」,共享夹具 / mock 仍写「待验证接入」。已对齐到产品文案,没有改回产品字符串。验证
Kiro slash(
daed5ccf)过滤测试已过。夹具修绿在932d0c7b。本 tip 只改 STATUS:pnpm check:docs通过。未改产品 / UI。范围
发现 / 注入路径 + catalog 夹具对齐 + STATUS 真窗记录。不改设置 IA,不合入。