types: TS conformance Rounds 6-11 — 216→250 Pass (symbol members, operators, class/interface checks)

Parsing/AST.cs

@@ -440,7 +440,9 @@ public record While(Expr Condition, Stmt Body) : Stmt;
     public record For(Stmt? Initializer, Expr? Condition, Expr? Increment, Stmt Body) : Stmt;
     public record DoWhile(Stmt Body, Expr Condition) : Stmt;
     public record ForOf(Token Variable, string? TypeAnnotation, Expr Iterable, Stmt Body, bool IsAsync = false) : Stmt;
-    public record ForIn(Token Variable, string? TypeAnnotation, Expr Object, Stmt Body) : Stmt;
+    // IsDeclaration distinguishes `for (var x in o)` (a fresh binding) from `for (x in o)`
+    // (assignment to an existing lvalue) — the latter's target type is validated (TS2405).
+    public record ForIn(Token Variable, string? TypeAnnotation, Expr Object, Stmt Body, bool IsDeclaration = true) : Stmt;
     public record If(Expr Condition, Stmt ThenBranch, Stmt? ElseBranch) : Stmt;
     public record Print(Expr Expr) : Stmt; // Temporary for console.log
     public record Break(Token Keyword, Token? Label = null) : Stmt;

Parsing/Parser.Statements.cs

@@ -168,7 +168,7 @@ private Stmt ForStatement()
             Stmt body = Statement();
             if (isOfLoop)
                 return new Stmt.ForOf(varName, null, rhs, body, isAsync);
-            return new Stmt.ForIn(varName, null, rhs, body);
+            return new Stmt.ForIn(varName, null, rhs, body, IsDeclaration: false);
         }
 
         // Traditional for loop without let/const

SharpTS.TypeScriptConformance/baselines/interpreted.txt

@@ -39,7 +39,7 @@ tests/cases/conformance/es2019/importMeta/importMetaNarrowing.ts Fail
 tests/cases/conformance/es2020/bigintMissingES2019.ts Pass
 tests/cases/conformance/es2020/bigintMissingES2020.ts Pass
 tests/cases/conformance/es2020/bigintMissingESNext.ts Pass
-tests/cases/conformance/es2020/constructBigint.ts Fail
+tests/cases/conformance/es2020/constructBigint.ts Pass
 tests/cases/conformance/es2020/es2020IntlAPIs.ts Fail
 tests/cases/conformance/es2020/intlNumberFormatES2020.ts Pass
 tests/cases/conformance/es2020/localesObjectArgument.ts Pass
@@ -71,7 +71,7 @@ tests/cases/conformance/es2023/intlNumberFormatES5UseGrouping.ts Fail
 tests/cases/conformance/es6/Symbols/symbolDeclarationEmit1.ts Pass
 tests/cases/conformance/es6/Symbols/symbolDeclarationEmit10.ts Pass
 tests/cases/conformance/es6/Symbols/symbolDeclarationEmit11.ts Pass
-tests/cases/conformance/es6/Symbols/symbolDeclarationEmit12.ts Fail
+tests/cases/conformance/es6/Symbols/symbolDeclarationEmit12.ts Pass
 tests/cases/conformance/es6/Symbols/symbolDeclarationEmit13.ts Pass
 tests/cases/conformance/es6/Symbols/symbolDeclarationEmit14.ts Pass
 tests/cases/conformance/es6/Symbols/symbolDeclarationEmit2.ts Pass
@@ -83,14 +83,14 @@ tests/cases/conformance/es6/Symbols/symbolDeclarationEmit7.ts Pass
 tests/cases/conformance/es6/Symbols/symbolDeclarationEmit8.ts Pass
 tests/cases/conformance/es6/Symbols/symbolDeclarationEmit9.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty1.ts Pass
-tests/cases/conformance/es6/Symbols/symbolProperty10.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty11.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty12.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty10.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty11.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty12.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty13.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty14.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty15.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty16.ts Pass
-tests/cases/conformance/es6/Symbols/symbolProperty17.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty17.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty18.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty19.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty2.ts Pass
@@ -104,23 +104,23 @@ tests/cases/conformance/es6/Symbols/symbolProperty26.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty27.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty28.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty29.ts Pass
-tests/cases/conformance/es6/Symbols/symbolProperty3.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty30.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty3.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty30.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty31.ts Pass
-tests/cases/conformance/es6/Symbols/symbolProperty32.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty33.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty32.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty33.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty34.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty35.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty36.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty35.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty36.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty37.ts TypeCheckError
 tests/cases/conformance/es6/Symbols/symbolProperty38.ts Pass
-tests/cases/conformance/es6/Symbols/symbolProperty39.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty39.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty4.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty40.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty41.ts Pass
-tests/cases/conformance/es6/Symbols/symbolProperty42.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty43.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty44.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty42.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty43.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty44.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty45.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty46.ts Fail
 tests/cases/conformance/es6/Symbols/symbolProperty47.ts Fail
@@ -129,9 +129,9 @@ tests/cases/conformance/es6/Symbols/symbolProperty49.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty5.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty50.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty51.ts Pass
-tests/cases/conformance/es6/Symbols/symbolProperty52.ts Skipped:lib-drift
-tests/cases/conformance/es6/Symbols/symbolProperty53.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty54.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty52.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty53.ts Pass
+tests/cases/conformance/es6/Symbols/symbolProperty54.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty55.ts Fail
 tests/cases/conformance/es6/Symbols/symbolProperty56.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty57.ts Pass
@@ -140,23 +140,23 @@ tests/cases/conformance/es6/Symbols/symbolProperty59.ts Fail
 tests/cases/conformance/es6/Symbols/symbolProperty6.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty60.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty61.ts Fail
-tests/cases/conformance/es6/Symbols/symbolProperty7.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty7.ts Pass
 tests/cases/conformance/es6/Symbols/symbolProperty8.ts Pass
-tests/cases/conformance/es6/Symbols/symbolProperty9.ts Fail
+tests/cases/conformance/es6/Symbols/symbolProperty9.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType1.ts Fail
 tests/cases/conformance/es6/Symbols/symbolType10.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType11.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType12.ts Pass
-tests/cases/conformance/es6/Symbols/symbolType13.ts Fail
-tests/cases/conformance/es6/Symbols/symbolType14.ts Fail
+tests/cases/conformance/es6/Symbols/symbolType13.ts Pass
+tests/cases/conformance/es6/Symbols/symbolType14.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType15.ts Fail
 tests/cases/conformance/es6/Symbols/symbolType16.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType17.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType18.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType19.ts Pass
-tests/cases/conformance/es6/Symbols/symbolType2.ts Fail
-tests/cases/conformance/es6/Symbols/symbolType20.ts Fail
-tests/cases/conformance/es6/Symbols/symbolType3.ts Fail
+tests/cases/conformance/es6/Symbols/symbolType2.ts Pass
+tests/cases/conformance/es6/Symbols/symbolType20.ts Pass
+tests/cases/conformance/es6/Symbols/symbolType3.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType4.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType5.ts Pass
 tests/cases/conformance/es6/Symbols/symbolType6.ts Pass
@@ -247,17 +247,17 @@ tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/enumIsNotA
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/nullIsSubtypeOfEverythingButUndefined.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/stringLiteralTypeIsSubtypeOfString.ts Fail
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfAny.ts Pass
-tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameter.ts Fail
+tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameter.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameterWithConstraints.ts Pass
-tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameterWithConstraints2.ts Fail
-tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameterWithConstraints3.ts Fail
-tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameterWithConstraints4.ts Fail
+tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameterWithConstraints2.ts Pass
+tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameterWithConstraints3.ts Pass
+tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameterWithConstraints4.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfTypeParameterWithRecursiveConstraints.ts Fail
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypesOfUnion.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignatures.ts Pass
-tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignatures2.ts Fail
-tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignatures3.ts Fail
-tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignatures4.ts Fail
+tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignatures2.ts Pass
+tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignatures3.ts Pass
+tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignatures4.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignaturesA.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignaturesWithOptionalParameters.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithCallSignaturesWithRestParameters.ts Pass
@@ -288,7 +288,7 @@ tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingW
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithObjectMembersOptionality2.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithObjectMembersOptionality3.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithObjectMembersOptionality4.ts Pass
-tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithOptionalProperties.ts Fail
+tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithOptionalProperties.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithStringIndexer.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithStringIndexer2.ts Pass
 tests/cases/conformance/types/typeRelationships/subtypesAndSuperTypes/subtypingWithStringIndexer3.ts Pass

TypeSystem/TypeChecker.Calls.cs

@@ -417,9 +417,11 @@ private bool TryCheckBuiltinCall(Expr.Call call, out TypeInfo result)
                 throw new TypeCheckException("BigInt() requires exactly one argument.", tsCode: "TS2554");
             }
             var argType = CheckExpr(call.Arguments[0]);
-            if (!IsNumber(argType) && !IsString(argType) && !IsBigInt(argType) && argType is not TypeInfo.Any)
+            // BigInt's parameter type is `string | number | bigint | boolean` (a boolean coerces to 0n/1n).
+            bool isBoolean = argType is TypeInfo.Primitive { Type: TokenType.TYPE_BOOLEAN } or TypeInfo.BooleanLiteral;
+            if (!IsNumber(argType) && !IsString(argType) && !IsBigInt(argType) && !isBoolean && argType is not TypeInfo.Any)
             {
-                throw new TypeCheckException($"BigInt() argument must be a number, string, or bigint, got '{argType}'.", tsCode: "TS2345");
+                throw new TypeCheckException($"BigInt() argument must be a number, string, bigint, or boolean, got '{argType}'.", tsCode: "TS2345");
             }
             { result = new TypeInfo.BigInt(); return true; }
         }

TypeSystem/TypeChecker.Compatibility.Helpers.cs

@@ -784,7 +784,8 @@ private Dictionary<string, TypeInfo> CollectGenericClassMembers(TypeInfo.Generic
     /// generic type arguments substituted. Returns false for branded or member-less/index-less targets
     /// (those stay nominal).
     /// </summary>
-    private bool StructurallyAssignableToClassTarget(TypeInfo targetResolved, TypeInfo source)
+    private bool StructurallyAssignableToClassTarget(TypeInfo targetResolved, TypeInfo source,
+        bool emptyTargetAcceptsObjectSource = false)
     {
         Dictionary<string, TypeInfo> members;
         bool hasIndex;
@@ -813,7 +814,11 @@ private bool StructurallyAssignableToClassTarget(TypeInfo targetResolved, TypeIn
             default:
                 return false;
         }
-        if (members.Count == 0 && !hasIndex) return false;
+        // A member-less, index-less unbranded target is structurally `{}`. For class-vs-class this
+        // stays nominal (caller passes false, preserving subclass-safety), but an object-like source
+        // (interface value / record) IS assignable to `{}` — that's the emptyTargetAcceptsObjectSource
+        // path, so `interface I → empty class C` no longer spuriously fails.
+        if (members.Count == 0 && !hasIndex) return emptyTargetAcceptsObjectSource;
         return CheckStructuralCompatibility(members, source) && IndexSignaturesSatisfied(indexCarrier, source);
     }
 

TypeSystem/TypeChecker.Compatibility.Relations.cs

@@ -93,7 +93,22 @@ private bool TryRelateTypeParameters(TypeInfo expected, TypeInfo actual, out boo
                 return true;
             }
             var apparent = ApparentTypeOf(actualTpOnly);
-            result = apparent != null && IsCompatible(expected, apparent);
+            if (apparent == null)
+            {
+                // An unconstrained type parameter has no apparent (constraint) type. tsc still relates
+                // it to a target that requires NO members — an all-optional / empty object type — its
+                // "subtyping assumes transitivity for optional properties (99% case)" allowance. It is
+                // NOT assignable to a primitive, `object`, or any target with a required member.
+                result = expected switch
+                {
+                    TypeInfo.Record rec => HasNoRequiredMembers(rec),
+                    TypeInfo.Interface itf => !itf.HasIndexSignature && !itf.IsCallable && !itf.IsConstructable
+                        && itf.GetAllMembers().All(m => itf.GetAllOptionalMembers().Contains(m.Key)),
+                    _ => false
+                };
+                return true;
+            }
+            result = IsCompatible(expected, apparent);
             return true;
         }
         result = false;

TypeSystem/TypeChecker.Compatibility.cs

@@ -422,6 +422,23 @@ private bool IsCompatibleCore(TypeInfo expected, TypeInfo actual)
         if (!_strictNullChecks && actual is TypeInfo.Null or TypeInfo.Undefined)
             return expected is not TypeInfo.Never;
 
+        // Namespace/module types (typeof someNamespace / typeof import(...)) have no dedicated
+        // relation anywhere below, so two structurally-identical namespaces — even the exact same
+        // one referenced twice, e.g. `true ? af : null` vs `true ? null : af` — fell through to the
+        // generic `return false` at the bottom, making a namespace type spuriously incompatible with
+        // ITSELF. Relate them structurally, like an object/record: every member `expected` exposes
+        // must exist on `actual` with a compatible type.
+        if (expected is TypeInfo.Namespace expNs && actual is TypeInfo.Namespace actNs)
+        {
+            return expNs.Types.All(kv => actNs.Types.TryGetValue(kv.Key, out var t) && IsCompatible(kv.Value, t))
+                && expNs.Values.All(kv => actNs.Values.TryGetValue(kv.Key, out var v) && IsCompatible(kv.Value, v));
+        }
+        if (expected is TypeInfo.Module expMod && actual is TypeInfo.Module actMod)
+        {
+            return expMod.Exports.All(kv => actMod.Exports.TryGetValue(kv.Key, out var v) && IsCompatible(kv.Value, v))
+                && (expMod.DefaultExport is null || (actMod.DefaultExport is not null && IsCompatible(expMod.DefaultExport, actMod.DefaultExport)));
+        }
+
         // Expand recursive type aliases lazily
         if (expected is TypeInfo.RecursiveTypeAlias expectedRTA)
         {
@@ -970,7 +987,7 @@ actualIG.GenericDefinition is TypeInfo.GenericClass gc2 &&
         // interface/record) are handled by the structural paths below.
         if (expected is TypeInfo.Instance targetInst &&
             actual is TypeInfo.Interface or TypeInfo.Record &&
-            StructurallyAssignableToClassTarget(targetInst.ResolvedClassType, actual))
+            StructurallyAssignableToClassTarget(targetInst.ResolvedClassType, actual, emptyTargetAcceptsObjectSource: true))
         {
             return true;
         }