Skip to content

Set collection from URL - #1

Open
raphaeltraviss wants to merge 3 commits into
nicoglennon:mainfrom
raphaeltraviss:feature/collection-url
Open

Set collection from URL#1
raphaeltraviss wants to merge 3 commits into
nicoglennon:mainfrom
raphaeltraviss:feature/collection-url

Conversation

@raphaeltraviss

@raphaeltraviss raphaeltraviss commented Oct 22, 2021

Copy link
Copy Markdown

Before this PR: you could drop a link to your ENS, and people come into the app looking at your wallet overview

After this PR: you can link direct to a particular collection you want to show off:

  • As the owner, I click on a collection, and the URL is updated with the collection name
  • As a viewer, I click the URL, and my browser opens eth.af with my wallet pre-populated, and it automatically loads that particular collection

NOTE: I'd recommend we go with URL routes like my-wallet/collection/some-collection-address:

  • prepend "collection" in case we have other things we want to use the URL for in the future
  • use the collection address instead of the contract name, since it could have weird characters
  • --> let me know if you think this is a good idea
  • right now it just jams the contract name in the URL and that's it

ethaf_feature

@vercel

vercel Bot commented Oct 22, 2021

Copy link
Copy Markdown

Someone is attempting to deploy a commit to a Personal Account owned by @nicoglennon on Vercel.

@nicoglennon first needs to authorize it.

@vercel

vercel Bot commented Dec 2, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ocin/amulet/BmLMAW1X2jSfdzcvxuGQnFDqFkND
✅ Preview: https://amulet-git-fork-raphaeltraviss-feature-collection-url-ocin.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant