ci: run the checks through yatr - #1
Open
cargopete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
yatr cilocally the same gate as CI, by moving the commands intoyatr.tomland having the workflow call them by name.What changed
yatr.tomltasks now mirror this workflow's commands exactly, flag for flag. Where the existing config had drifted from CI, CI won and the config was corrected to match.yatrinstall, pinned via aYATR_VERSIONworkflow env.run:that was a check command becomesrun: yatr <task>.What deliberately did not change
Job structure, toolchains, caching actions, system dependencies, matrices and any job that was not a check pipeline are all untouched. This is a per-step substitution, not a per-job collapse, so coverage is identical.
Notes
RUSTFLAGSfor that step only. yatr is a different crate and must not inherit this project's flags: a-D warningswould fail its build on any dependency warning, and a custom linker flag would fail if that linker is only installed in another job.ci, notcheck, becauseyatr checkis a builtin that validates the config file and shadows a task of that name without warning (Tasks named after builtin subcommands are listed but unreachable, silently (yatr's ownchecktask included) cargopete/yatr#4).actions/cacheentry makes it near-instant. BumpingYATR_VERSIONinvalidates it deliberately.Opened as a PR rather than pushed to the default branch because a workflow change can only really be verified by CI running it. Merge once this run is green.