fix: clear filter functionality#114
Conversation
|
@ShaikhGouhar is attempting to deploy a commit to the niharika-mente's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesClear Filters Feature
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@components/SearchFilters.tsx`:
- Around line 45-60: In the handleClearFilters function, the URL parameters are
being cleared but the local search state (referenced on line 23) is not being
reset, causing the search input to display stale query text while the URL is
updated. Add a call to reset the search state variable to an empty string or its
initial value alongside the URL parameter deletion. Additionally, fix the
formatting by adding a space before the opening brace in the function
declaration and correct the indentation throughout the function body to maintain
consistency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9f50bc1d-65e1-417c-bc74-e5aca1963f5c
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json,!package-lock.json
📒 Files selected for processing (2)
components/SearchFilters.tsxpackage.json
|
Issue Number; #70 Add issue number in desc too! |
TarunyaProgrammer
left a comment
There was a problem hiding this comment.
A couple of minor suggestions:
- The button currently uses
flex flex-col justify-end, which isn't needed for a single text element and can be simplified. - Consider adding
cursor-pointer, a hover state, and usingrounded-lgto better match the styling of other interactive elements in the application.
Also, the PR includes MongoDB/Mongoose dependency upgrades. It may be preferable to keep dependency updates in a separate PR from feature changes to make testing and troubleshooting easier if issues arise.
|
@TarunyaProgrammer , here is the requested changes , if any other changes are require ,please let me know |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue number)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
Summary by CodeRabbit
Release Notes