Share spatial index validation between models and migrations - #334
Draft
nikitasavinov wants to merge 1 commit into
Draft
nikitasavinov wants to merge 1 commit into
nikitasavinov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spatial index restrictions were duplicated between design-time model validation and migration SQL generation. Both paths now call
SpatialIndexAnnotation.ValidateIndex, removing 40 lines of production code while preserving the spatial type, bounding-box, primary-key, and SQL generation checks.Expand the existing raw-operation test to cover clustered indexes, included columns, ONLINE, fill factor, tempdb sorting, and compression, including explicitly disabled unsupported options.
Validation: 132 tests passed with
dotnet test --solution EntityFrameworkCore.Extensions.sln --configuration Release --no-restore; five SQL Server integration tests were skipped because no connection was configured. Formatting verification for all four changed files andgit diff --checkpassed.