[Outbound-Proxy] Use SRV Logic only if remote-port is not defined#99
Open
bundasmanu wants to merge 1 commit into
Open
[Outbound-Proxy] Use SRV Logic only if remote-port is not defined#99bundasmanu wants to merge 1 commit into
bundasmanu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this phase
SRVlogic is used if we don't pass a port in theSIP URIofOutbound-Proxyflag (-pflag). But,SRV lookupwill be executed even if we pass a remote port before (-rflag). And for my perspective,SRV lookupshould be skipped, if we pass a specific remote port in the command.The change added is not abusive, and seems to not break anything. If we want to continue use
SRV lookup, it's enough to didn't provideremote-portflag, of pass it after-pflag.Tested with multiple
transports, and passingIPsandhostnames. Also withport (in the -p flag), and withremote-portflag.Thanks @nils-ohlmeier