Skip to content

fix(api): unlist removed validator profiles#139

Merged
onmax merged 9 commits intomainfrom
fix/validator-profile-unlisted-lifecycle
Mar 2, 2026
Merged

fix(api): unlist removed validator profiles#139
onmax merged 9 commits intomainfrom
fix/validator-profile-unlisted-lifecycle

Conversation

@onmax
Copy link
Member

@onmax onmax commented Feb 25, 2026

Summary

  • add is_listed flag to validators
  • validators present in the bundled profile list are listed; validators removed from that list (or discovered without a bundled profile) are unlisted
  • unlisted validators keep row/history, but profile metadata is neutralized
  • only-known=true now uses listed state (with fallback for legacy NULL rows)
  • expose isListed on validator responses and unlistedActiveValidators on status

@onmax onmax temporarily deployed to preview-testnet February 25, 2026 20:44 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 25, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
validators-api-test f5c1adc Commit Preview URL

Branch Preview URL
Mar 02 2026, 10:57 AM

@onmax onmax temporarily deployed to preview-testnet February 25, 2026 20:50 — with GitHub Actions Inactive
@onmax onmax force-pushed the fix/validator-profile-unlisted-lifecycle branch from 064de84 to af0cc88 Compare February 25, 2026 20:54
@onmax onmax temporarily deployed to preview-testnet February 25, 2026 20:54 — with GitHub Actions Inactive
@onmax onmax changed the title fix(api): mark removed validator profiles as unlisted fix(api): unlist removed validator profiles Feb 25, 2026
@onmax
Copy link
Member Author

onmax commented Feb 25, 2026

@codex review

@onmax onmax requested a review from Albermonte February 25, 2026 21:21
@onmax onmax temporarily deployed to preview-testnet February 25, 2026 21:24 — with GitHub Actions Inactive
@onmax onmax temporarily deployed to preview-testnet February 25, 2026 21:32 — with GitHub Actions Inactive
@onmax onmax temporarily deployed to preview-testnet February 25, 2026 21:38 — with GitHub Actions Inactive
@onmax onmax temporarily deployed to preview-testnet February 25, 2026 21:51 — with GitHub Actions Inactive
@onmax onmax temporarily deployed to preview-testnet February 25, 2026 22:04 — with GitHub Actions Inactive
@onmax onmax temporarily deployed to preview-testnet February 25, 2026 22:10 — with GitHub Actions Inactive
@onmax onmax temporarily deployed to preview-testnet February 26, 2026 07:58 — with GitHub Actions Inactive
@Albermonte
Copy link
Member

why not just removing it from the db?
if validator not in the public/validators then remove from db

@onmax
Copy link
Member Author

onmax commented Feb 27, 2026

we track by default all validators in the db... also i am afraid of breaking the wallet somehow. Adding an additional field seems the best way for backward compat

@Albermonte
Copy link
Member

we track by default all validators in the db... also i am afraid of breaking the wallet somehow. Adding an additional field seems the best way for backward compat

adding an additional param requires more work in the wallet, just dont mark removed validators as known?
the validator is still active, it's just not a pool anymore

@onmax
Copy link
Member Author

onmax commented Feb 27, 2026

the validator does use another method to retrieve the validators from the blockchain. they don't use our api. Just to merge their addresses with the logo, description and score.

@onmax onmax temporarily deployed to preview-testnet March 2, 2026 10:54 — with GitHub Actions Inactive
@onmax onmax merged commit 9b31922 into main Mar 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants