Skip to content

test(engine): gate the catalog against the card that was printed #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ninthworld merged 1 commit into from
Aug 8, 2026
Merged

test(engine): gate the catalog against the card that was printed #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/sage-engine/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@
a functional definition per card under a stable `functional_id`, no presentation
assets (the schema rejects them structurally), and code-defined behavior only via the
declared `scripted` escape hatch.
- **A definition's printed characteristics are checked against the printed card, not
against the tests written over it.** `build.rs` validates *shape*; the accuracy gate is
`tests/printed_characteristics.rs`, reading a fixture transcribed from the set by
`scripts/printed-characteristics.py`. That script never reads `data/catalog/`, and it
must not: a fixture regenerated from the thing it checks is a gate that passes forever
and proves nothing. Rules text stays out of it — the project ships none, and a test
fixture is not an exception.
- **Never write a `CardId` down.** `build.rs` assembles `data/catalog/` + `data/sets/`
at compile time and interns `CardId(0..n)` from the sorted `FunctionalId`s (ADR 0008
§3), so authoring one card renumbers its neighbours. Name a card by its
Expand Down
Loading
Loading