Skip to content

Fix calibrate spectrum's use of modeless dialogs.#90

Merged
cmeyer merged 1 commit intonion-software:masterfrom
MattRoyle:error-dialog-fix
Mar 30, 2026
Merged

Fix calibrate spectrum's use of modeless dialogs.#90
cmeyer merged 1 commit intonion-software:masterfrom
MattRoyle:error-dialog-fix

Conversation

@MattRoyle
Copy link
Copy Markdown
Contributor

An error was appearing in the console when you tried to use calibrate spectrum on live data. show_modeless_dialog requires the handler to implement the method get_object_converter.

@MattRoyle MattRoyle self-assigned this Mar 26, 2026
@MattRoyle MattRoyle requested a review from cmeyer March 26, 2026 14:06
@MattRoyle MattRoyle requested a review from KRLango March 30, 2026 08:35
Copy link
Copy Markdown

@KRLango KRLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix seems sensible to me

@cmeyer cmeyer merged commit 95682ca into nion-software:master Mar 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants