Skip to content

Add comment regarding button behavior during requests #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julia-weppler-1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add comment regarding button behavior during requests #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/src/pages/ChallengesPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ function ChallengesPage({ currentUser }) {
)}

{creating && (
// it looks like all of your submit buttons stay enabled as a request is being handled. This could lead to unexpected behavior if a user gets
// frustrated and spams a submit or delete button before each request processes. Disabling the button until the request completes could be
// beneficial.
<form className={styles.challengeCreateForm} onSubmit={handleCreate}>
<h2 tabIndex={-1} ref={createHeadingRef}>
Post a challenge
Expand Down