Skip to content

Add usability feedback comments in App.jsx #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julia-weppler-1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add usability feedback comments in App.jsx #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ import LogWorkoutPage from "./pages/LogWorkoutPage";
import HistoryPage from "./pages/HistoryPage";
import ChallengesPage from "./pages/ChallengesPage";

// Overall, this is a great application that I would use personally and I appreciate the useability edits the authors have made since P3.
// Keyboard navigation works as expected and there are no issues reported by Axe Devtools. I left a few comments related to displaying warnings and
// code consistency. Great work!
function App() {
const [currentUser, setCurrentUser] = useState(null);
// check if there is a logged in session yet: used by Navbar, protectedroute and implicity to every ro
Expand Down