Skip to content

Recommendation to refactor GET method in challenges route #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julia-weppler-1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Recommendation to refactor GET method in challenges route #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/routes/challenges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ router.post("/", async (req, res) => {
// profile and this user's own acceptance (if any). Expired challenges the user
// never accepted are dropped, and any accepted challenge whose window has closed
// is resolved to completed/failed on the way out.

// This get is very long and performs a write operation. These are not technically bugs in the code
// but maybe it would be best to have a separate smaller method for the write which the get can call?
router.get("/", async (req, res) => {
try {
const myId = req.user._id.toString();
Expand Down