Skip to content

More robust user profile update comment #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julia-weppler-1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

More robust user profile update comment #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions server/routes/users.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ router.get("/:id", requireValidId, async (req, res) => {
});

// UPDATE a profile — only the logged-in user can edit their own profile
// this update does not enforce uniqueness, so even though a user must create a profile with a unique email/username,
// they can change it to an existing one. I would recommend adding the same checks that the register path has.
router.put("/:id", requireValidId, async (req, res) => {
try {
if (req.params.id !== req.user._id.toString()) {
Expand Down