Skip to content

Suggest error handling for user account deletion #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julia-weppler-1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Suggest error handling for user account deletion #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/pages/ProfilePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ function ProfilePage({ currentUser, onUserChange }) {
await fetch(`/api/users/${currentUser._id}`, { method: "DELETE" });
// clear the app-wide user, then back to the homepage — the account is gone,
// so a login form is the one page they can't use
// I would recommend error handling here so if the DELETE fails, the user isn't logged out and is instead shown a message.
onUserChange(null);
navigate("/");
}
Expand Down