Skip to content

Remove comment on auth middleware consistency #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julia-weppler-1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove comment on auth middleware consistency #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/routes/challenges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { usersDb } from "../db/usersDb.js";
import { requireValidId } from "../middleware/requireValidId.js";

const router = express.Router();

// It looks like you use auth middleware in your other routes, but not here. It is still enforced, but perhaps the code is just incosistent in where it is enforced
// today as a plain YYYY-MM-DD string, so it compares directly against the
// startDate/endDate strings a challenge stores (both are zero-padded ISO dates)
function todayString() {
Expand Down