fix : harden rehype-sanitize schema against SVG XSS and javascript: URL injection#2422
fix : harden rehype-sanitize schema against SVG XSS and javascript: URL injection#2422tmdeveloper007 wants to merge 1 commit into
Conversation
…RL injection Issue: nisshchayarathi#83 The default rehype-sanitize schema allows SVG elements which can carry event handlers (onload, onerror, etc.) that execute JavaScript. javascript: URLs in href/src attributes were also not explicitly blocked. Changes: - Create lib/utils/markdownSanitization.ts with createStrictMarkdownSchema() that strips SVG/foreignObject/use/symbol/defs elements entirely. - Block javascript:, data:, vbscript: URLs in all URL-carrying attributes. - Block CSS expression() and behavior injection in style attributes. - Strip all event-handler attributes (on*) from all elements. - Update AIChatInterface, AIRepoMentorSection, AIRepositoryOverlay to use strictMarkdownSchema and sanitize href with sanitizeMarkdownHref. - Add rel="noopener" to external links for additional security.
|
Someone is attempting to deploy a commit to the Nisshchaya's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reached
More reviews will be available in 56 minutes and 54 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return value | ||
| .replace(/expression\s*\(/gi, " blocked(") | ||
| .replace(/behavior\s*:/gi, " blocked:") | ||
| .replace(/url\s*\(/gi, " url(blocked") | ||
| .replace(/javascript:/gi, " blocked:") | ||
| .replace(/data:/gi, " blocked:"); |
|
Closing this PR. The branch is based on an older commit of upstream/main and has drifted from the current main. The upstream repository has received significant updates since this PR was opened, causing CI type-check and test failures due to merge conflicts with the base branch. Please re-open as a fresh PR against the current main if the fix is still needed. |
2 participants
Summary
The default rehype-sanitize schema allows SVG elements which can carry event handlers (onload, onerror) that execute JavaScript. javascript: URLs in href attributes were also not explicitly blocked.
Changes
Note
Assign to tmdeveloper007