Skip to content

fix : throw error on AI file selection parse failure instead of silently falling back#2481

Open
tmdeveloper007 wants to merge 1 commit into
nisshchayarathi:mainfrom
tmdeveloper007:fix/2472-ai-fallback-error
Open

fix : throw error on AI file selection parse failure instead of silently falling back#2481
tmdeveloper007 wants to merge 1 commit into
nisshchayarathi:mainfrom
tmdeveloper007:fix/2472-ai-fallback-error

Conversation

@tmdeveloper007

Copy link
Copy Markdown
Contributor

Summary

When AI returns unparseable JSON for the RAG file selection step in app/api/ai/chat/route.ts, the code silently fell back to candidatePaths.slice(0, 2). This could include irrelevant files and produce incorrect answers without any indication to the user.

Changes

  • app/api/ai/chat/route.ts: Throw a descriptive error when AI file selection JSON is unparseable or not an array, instead of silently falling back.

Impact

AI chat errors are now surfaced properly so callers can handle them gracefully rather than silently producing potentially incorrect answers.

Closes #2472

…tly falling back

When AI returns unparseable JSON for the RAG file selection step, the code
silently fell back to candidatePaths.slice(0, 2). This could include
irrelevant files and produce incorrect answers without any indication.
Now throws a descriptive error so the caller can handle it properly.

Closes nisshchayarathi#2472
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

@tmdeveloper007 is attempting to deploy a commit to the Nisshchaya's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@tmdeveloper007, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 52 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 93e780d7-e428-47b9-94f5-c7b56710400b

📥 Commits

Reviewing files that changed from the base of the PR and between cd4e69b and 4a912b5.

📒 Files selected for processing (1)
  • app/api/ai/chat/route.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the GSSoC'26 Part of GirlScript Summer of Code 2026 label Jun 24, 2026
@github-actions

Copy link
Copy Markdown

🎉 Thanks for your contribution, @tmdeveloper007!

Your PR has passed our automated GSSoC quality checks. Here's a quick summary:

Check Status
PR description ✅ Provided
PR title ✅ Meaningful
Linked issue ✅ Found
Change size ✅ Looks good (8 lines across 1 file(s))

A maintainer will review your PR soon. Please be patient and available for feedback. 💪

GSSoC'26 automation · Maintainer: @nisshchayarathi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSoC'26 Part of GirlScript Summer of Code 2026

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: AI file selection silently falls back to arbitrary files on JSON parse failure

1 participant