Add support for platform windows#112
Conversation
| "mingw" => [{engine: "mingw"}], | ||
| "truffleruby" => [{engine: "ruby"}], | ||
| "x64_mingw" => [{engine: "mingw"}], | ||
| "windows" => [{engine: "mswin"}, {engine: "mswin64"}, {engine: "mingw"}], |
There was a problem hiding this comment.
Wasn't 100% sure what engines to list here, but basically took the list from Gem::Platform::WINDOWS as defined here
|
@inscapist would we be able to get this merged into your fork? |
|
For context it looks like “windows” was added as an alias for existing windows platforms in bundler: ruby/rubygems#5650 I encountered the issue as new Rails app Gemfiles use this alias instead of the mingX platforms it did before. |
|
@manveru Any chance you could take a look at this? If a gem like irb gets updated now, this results in an unclear error I tried these changes in a repository where I ran into this issue and they generated the expected gemset. |
|
Is there a way to get this merged? |
Fixes #57
Several gems declare platform support for
windows, including several dependencies of a newly-generatedrailsapp