fix: include windows platform and use filter_map#122
Open
BSFishy wants to merge 1 commit intonix-community:masterfrom
Open
fix: include windows platform and use filter_map#122BSFishy wants to merge 1 commit intonix-community:masterfrom
BSFishy wants to merge 1 commit intonix-community:masterfrom
Conversation
Signed-off-by: Matt Provost <mattprovost6@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had bundix start failing for me with this error:
I tracked it down to a missing
windowsplatform, which is now added in this PR. I also changed the map to afilter_mapto prevent something like this happening in the future, but can remove if that's not desirable