Skip to content

enable warpbuild cache#321

Draft
jkelleyrtp wants to merge 3 commits into
nix-community:mainfrom
jkelleyrtp:jk/use-warpbuild
Draft

enable warpbuild cache#321
jkelleyrtp wants to merge 3 commits into
nix-community:mainfrom
jkelleyrtp:jk/use-warpbuild

Conversation

@jkelleyrtp
Copy link
Copy Markdown

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DSharifi
Copy link
Copy Markdown

DSharifi commented Apr 1, 2026

Great to see you're working on this @jkelleyrtp!

Is this something you think we'll able to merge any time soon?

@jkelleyrtp
Copy link
Copy Markdown
Author

jkelleyrtp commented Apr 10, 2026

Great to see you're working on this @jkelleyrtp!

Is this something you think we'll able to merge any time soon?

Hi! Yes! We're using it for dioxuslabs/dioxus - seems to function well. However it was pretty AI generated so I'll need to spend time getting it into a more mergable state.

The diff should be quite small - the warpbuild sdk being inlined is here because there are a few bugs in the warpbuild sdk that needed to be fixed via vendoring.

@DSharifi
Copy link
Copy Markdown

Great to see you're working on this @jkelleyrtp!
Is this something you think we'll able to merge any time soon?

Hi! Yes! We're using it for dioxuslabs/dioxus - seems to function well. However it was pretty AI generated so I'll need to spend time getting it into a more mergable state.

The diff should be quite small - the warpbuild sdk being inlined is here because there are a few bugs in the warpbuild sdk that needed to be fixed via vendoring.

@jkelleyrtp thanks for getting WarpBuilds/toolkit#17 through. Do you have time in the near future to update this PR to pull in the latest buildkit with the merged changes?

Otherwise I'm happy to take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants