feat: support inline plugin merging by name - #617
Merged
Merged
Conversation
Shared plugin files previously replaced the complete inherited inline plugin list. Add per-file name merging and removal controls while keeping replacement as the default for existing configurations. Closes #616
Greptile SummaryThis PR adds opt-in, per-file merging and removal of inline plugins while preserving whole-list replacement as the default.
Confidence Score: 5/5The PR appears safe to merge; the implementation matches the documented per-file semantics and no actionable defects were identified. Plugin controls are validated and applied once per source file, merge ordering remains base-to-drop-in-to-cluster-to-context, and package and bundled-plugin loading remains downstream and unchanged. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Base configuration] --> B[Apply base plugin controls]
B --> C[conf.d files in filename order]
C --> D[Apply each file's removals]
D --> E{plugins_merge}
E -->|replace, default| F[Replace inherited plugin array]
E -->|name| G[Replace matching names in place<br/>append new names]
F --> H[Cluster override]
G --> H
H --> I[Context override]
I --> J[Deserialize resolved Config]
J --> K[Load package plugins]
K --> L[Add non-conflicting bundled plugins]
Reviews (1): Last reviewed commit: "feat: support inline plugin merging by n..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared inline plugins in
conf.d/currently replace the complete inherited plugin list. Add per-fileplugins_merge = "name"so shared and personal plugins can coexist. Replacement remains the default for existing configurations.In name mode, later entries replace complete definitions with the same name and keep their position. New names are appended.
plugins_removeremoves inherited inline entries before that file adds entries. Both controls apply only to their own file. Package and bundled-plugin loading stays unchanged.Includes TOML/YAML configuration tests, a keyboard-driven
:reloadtest, and configuration documentation.Validation:
just check, Markdown formatting, andgit diff --checkpassed.Agreed discussion: #603 (comment)
Closes #616