fix: show inventory of the selected resource - #619
Merged
Merged
Conversation
The GitOps report read inventory from the owner, so a selected Kustomization showed resources managed by its parent. Read inventory from the selected resource on open and refresh. Closes #618
Greptile SummaryThe PR corrects the GitOps Managed resources section to use the freshly read selected resource rather than its resolved Flux owner.
Confidence Score: 5/5The PR appears safe to merge, with the implementation, regression coverage, and documentation aligned on selected-resource inventory behavior. No actionable failures remain; the changed lookup uses the same freshly fetched selected object for both initial display and refresh, while existing inventory parsing continues to handle remote configuration and absent entries. Important Files Changed
Reviews (1): Last reviewed commit: "fix: show inventory of the selected reso..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitOps view showed the owner's inventory when the selected resource had a Flux owner label. Read
.status.inventory.entriesandspec.kubeConfigfrom the selected resource so that Managed resources shows the resources it manages.Add a regression test that opens the view through the command input and refreshes it through the keyboard. The test checks the selected inventory, navigation with a remote parent, and removal of old entries when inventory is absent. Update the feature documentation.
Validation:
just checkpassed, including formatting, clippy, and tests.Closes #618