feat: complete CLI argument values - #627
Merged
Merged
Conversation
|
The completion timeout only cleaned up process groups on Unix, and install suggestions bypassed catalog eligibility checks. Hold Windows workers until Job Object setup succeeds and close the job to terminate descendants. Reuse catalog selection rules for install candidates while preserving describe results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI completion supplied option names and fixed values, but no context or namespace values. This change adds value completion for all applicable CLI arguments in Bash, Zsh, Fish, Elvish, and PowerShell.
Discussion: #620. The maintainer approved the expanded scope in the implementation session. Follow-up to #621 and #621 (comment).
Validation:
just checkpassed. Tests cover all five shell interfaces, kubeconfig merging, context selection, mocked namespace and discovery APIs, plugin metadata, paths, timeouts, and configuration preservation. Generated Bash and Fish scripts passed execution checks; Zsh and Fish passed syntax checks. Elvish and PowerShell were tested through their completion interfaces, without running those shells.Users must reload their completion scripts after installing the update. Plugin catalog suggestions use the local cache. The CLI has no object-name argument, so resource suggestions are resource types only.
The Windows cleanup module and its process-tree test passed cross-compilation and Clippy checks for
x86_64-pc-windows-gnu. Native Windows execution was not available on the development host.