fix: decode colons in Flux inventory resource names - #628
Merged
Merged
Conversation
Parse inventory fields from the outer separators so encoded colons remain in the resource name. Decode the name for display and navigation. Closes #626
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flux inventory entries with colons in RBAC resource names showed
invalid inventory entry. The parser treated the encoded__in each name as field separators.Parse the namespace from the start and the kind and API group from the end, then convert
__back to:in the name. The managed resource row and Enter navigation now use the decoded name.Tests cover Role, RoleBinding, ClusterRole, and ClusterRoleBinding names in both Kustomization and HelmRelease views, including names with multiple colons.
Validation:
just check(format check, Clippy, and tests).Closes #626