Conversation
The RLS lockdown on orders (closing the client-trusted-price hole) left the reviews INSERT policy unable to verify order completion -- its subquery against orders ran under the anonymous customer's own RLS, which can no longer see into orders at all, so the check always failed regardless of actual status. Customers saw the raw Postgres error. Fixed by checking completion through a SECURITY DEFINER function instead (same pattern as is_admin()), and replaced the raw error text shown on submission failure with a generic message.
fix: reviews couldn't be submitted for completed orders
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.