Party/action highlight detection (saliency candidate source)#44
Open
nmbrthirteen wants to merge 3 commits into
Open
Party/action highlight detection (saliency candidate source)#44nmbrthirteen wants to merge 3 commits into
nmbrthirteen wants to merge 3 commits into
Conversation
Auto-cut highlight clips from footage with no useful transcript (party videos, action) by peak-picking a fused laughter+energy curve instead of reading the transcript. Selected via 'podcli process --profile party|action'. - saliency.py: per-video robust-z normalization (median/MAD, never global), weighted channel fusion, numpy peak-pick with min-gap NMS, reaction dilation so a brief laugh isn't drowned by a louder neighbor, reaction-first candidate generation, 8s backward expansion to capture the setup before a laugh, and quiet-point boundary snapping - profiles drive it: 'saliency' candidate source (party/action) vs 'llm' (podcast) picks the selection path in the process pipeline - deterministic on clean input; produces render-compatible clip dicts Thresholds and channel weights are starting points to be tuned on real party footage.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Register a detect_highlights task handler so the MCP/web backend can run party/ action highlight detection via the python-executor, not just the CLI. Verified end to end through the stdin dispatch.
Add detect_highlights_pooled and accept video_paths in the detect_highlights task: run detection over many videos, tag each clip with its source_file, and rank globally reaction-first. Serves the 'best N moments across a folder of party clips' use case. Verified across two clips via the backend dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #43.
What
Auto-cut highlight clips from footage with no useful transcript (party videos, action). New
podcli process --profile party|actionpicks moments by peak-picking a fused laughter+energy curve instead of reading the transcript.How
backend/services/saliency.py— the fusion engine:profiles.pycandidate source routes selection:saliency(party/action) vsllm(podcast). Wired into theprocesspipeline Step 3 and the--profileflag.Validated
test_ai_fallbackenv failures.Honest caveats
processStep 1 is mandatory). Skipping transcription for saliency profiles on long videos is a follow-up optimization.profilethreading (MCP/web UI) is not in this PR — CLI only for now.See
plans/moment-detection.mdfor the full design and phasing.