Merged
Conversation
added 29 commits
July 14, 2025 14:17
…ancel concurrent actions
e-perl-NOAA
added
workflows
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
iantaylor-NOAA
approved these changes
Jul 15, 2025
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
@e-perl-NOAA, thanks for working on this. The changes look good to me. I'm no expert on shell scripts, but since it solved the problem @arni-magnusson was facing, clearly it worked. Unless you see a reason not to, I would accept the permissions-related change that the github copilot review suggested.
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Collaborator
Author
|
@Rick-Methot-NOAA can you give this a look? |
Rick-Methot-NOAA
approved these changes
Jul 22, 2025
Collaborator
Rick-Methot-NOAA
left a comment
Rick-Methot-NOAA
left a comment
There was a problem hiding this comment.
I totally support the concepts implemented here. Proof is in the results. I presume that the security alert now disappears?
Collaborator
Author
|
I don't think it does anything to the security alert. |
|
Here are the successful executable builds from your PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
Resolves and closes issue #685
What tests have been done?
Where are the relevant files?
What tests/review still need to be done?
None.
Is there an input change for users to Stock Synthesis?
Additional information (optional).